Add #[must_use] attribute to some DynamicImage methods
#2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an API improvement to make it clear to users that most of the methods on `DynamicImage` are non-mutating.
HeroicKatora
approved these changes
Jun 28, 2024
kornelski
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for maintaining such a helpful crate. This PR is a small API improvement to make it clear to users that most of the methods on
DynamicImageare non-mutating. #1736 along with my own usage of this crate suggest that it would be helpful to make these methods#[must_use].Let me know if there's some reason that we're not using
#[must_use]already, and if there are some methods that warrant or don't warrant being marked with this attribute.I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.