Switch to miniz_oxide #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perf is spectacular: |
HeroicKatora
force-pushed
the
miniz-oxide
branch
from
34ce181
to
7007eb2
Compare
The main point is that it should be possible to control all allocations performed, even though this commit does not yet do it.
All data in an image must appear in consecutive IDAT/fdAT chunks that are not interrupted by any other data chunk. In particular we should not ignore intermediate chunks but report them as an error (see 5.6. Chunk Ordering). This is also important to properly flush the zlib decompression at the end of the subframe and retrieve remaining rows as well as check its checksum even if ignored blocks follow.
HeroicKatora
force-pushed
the
miniz-oxide
branch
from
7007eb2
to
5658bad
Compare
This test ensures that we do not silently ignore an invalid chunk that was inserted between IDAT chunks. This should error according to the png specification. The property of consecutive chunks is checked since the zlib decoder must be signalled the end of the compressed data stream.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a few instances where decoding should fail. The theory behind these was realized because
miniz_oxideforces us to manually flush the decompression at the end of consecutive IDAT chunks which in turns requires us to keep track of this.Fixes: #217
Closes: #151