-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
png-afl fuzzer is broken #132
Comments
I'm currently running the fuzzer for 1 hour straight, this might be a setup issue? |
Maybe I'm not expressing myself clearly :) |
Seems to me the png-afl\src\main.rs exits with SIGABORT when an error is returned from png decoding.
|
The default memory limit of
instead. |
The |
You're right, raising memory limit is solving the issue I was seeing! 100m not enough for me though, but 200 seems to do it! |
Glad I opened this issue, or I would be stuck forever. The following line disables crc check on decoding https://github.com/image-rs/image-png/blob/master/src/decoder/stream.rs#L245 assuming afl is invoked with env RUSTFLAGS='--cfg fuzzing' set |
That should probably both be explain in a readme in the |
Also not sure this is the correct way to use cfg!().. reading up on it now |
Shouldn't |
We could also provide an explicit |
It should yes. Yea, setting the feature in Cargo.toml sounds good to me, less moving parts for the user. |
The afl fuzzer target in ./png-afl currently exits with SIGABRT as soon as any decoding errors occurs, causing AFL to think for example "CRC mismatch" is a crashing input file.
The text was updated successfully, but these errors were encountered: