Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis-CI fails on minimal versions #113

Closed
HeroicKatora opened this issue Apr 19, 2019 · 1 comment · Fixed by #120
Closed

Travis-CI fails on minimal versions #113

HeroicKatora opened this issue Apr 19, 2019 · 1 comment · Fixed by #120

Comments

@HeroicKatora
Copy link
Member

HeroicKatora commented Apr 19, 2019 •
edited

The command cargo +nightly test -Z minimal-versions does not succeed on Windows machines, due to resolving to version 0.0.1 of winapi. This crate version contains invalid syntax. Two options:

  1. Do not execute cargo test on nightly with minimal-versions
  2. Declare minimum versions that resolve correctly
@HeroicKatora HeroicKatora mentioned this issue Apr 23, 2019
Merged
HeroicKatora added a commit to HeroicKatora/image-png that referenced this issue Apr 28, 2019
@HeroicKatora
Avoid compiling dev-dependencies with minimal versions
ee002fa 
Works around an issue where no version of `glium` actually depends on
semantically valid crates with `minimal-versions` enabled. Tests and
examples are still compiled and/or ran on other configurations.

Closes: image-rs#113
@HeroicKatora HeroicKatora mentioned this issue Apr 28, 2019
Merged
@HeroicKatora
Copy link
Member Author

There are in fact a lot of crates with dependencies that do not work properly with minimal-versions:

  • term = 0.4 -- winapi = 0.0.1!
  • glium = 0.22 -- winapi = 0.0.1!
  • glium = 0.24 -- lazy_static = 0.1.0!

See #119 for the full dependency chains. Especially glium complicates the matter as there is no newer version available and the project seems to be in maintenance-only mode. This makes the first option more appealing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid compiling dev-dependencies with minimal versions HeroicKatora/image-png
1 participant
@HeroicKatora