-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A tutorial for creating Westeros multi-node and modeling different trade possibilities #683
A tutorial for creating Westeros multi-node and modeling different trade possibilities #683
Conversation
Codecov Report
@@ Coverage Diff @@
## main #683 +/- ##
=====================================
Coverage 94.9% 94.9%
=====================================
Files 42 42
Lines 3400 3400
=====================================
Hits 3229 3229
Misses 171 171 |
fe0e8ad
to
37be800
Compare
All checks were successful, but the branch was out of date. I rebased the branch so that we can merge it soon, but now the tests might fail due to the removal of codecov from PyPi, which will be fixed by |
Great tutorial! It showcases a lot of features and possibilities, which brings it to the more complex tutorials, but all the examples and exercises will enable people to understand it completely. On that note, I would really like to see solutions to the exercises, maybe at the end of the tutorial. That way, even people working through them without guidance at a workshop will be able to tell if they understood things correctly. Some notes:
Apart from that, this PR looks fine to me and is good to be merged :) |
Thanks, @glatterf42 for reviewing this and for the useful suggestions. I agree that adding solutions at the end here or somewhere else as key to exercises, in general, will be useful. For this tutorial, the given exercise involves developing a scenario, with the intention to encourage users to do hands-on work. I'm afraid adding that solution here may not encourage users to start coding this.
|
Maybe you could add a statement like 'Self-supervised learners who would like to see a solution for these exercises: please contact the author.' |
Update tutorial for multinode and add images
a94afc3
to
7918bfd
Compare
This might then be ready for merging. |
Thanks @glatterf42 for reviewing and adding the hint for the exercise. I agree, this can be merged. @OFR-IIASA is that okay? |
For future reference: @OFR-IIASA confirmed privately that the merge is okay. |
This PR adds a new tutorial to demonstrate how a multi-node energy system can be built using the MESSAGEix framework. It shows:
message_ix
index set "mode" in representing trade linksHow to review
PR checklist
test_tutorials.py
)