New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add readers for java.time.LocalDate and Period #44

Merged

kailuowang merged 2 commits into iheartradio:master from crispywalrus:master

Nov 23, 2016

crispywalrus commented Nov 22, 2016

We started using these but as they're a built in java type I thought they might be more generally applicable.


          add readers for java.time.LocalDate and Period

fd8262b

coveralls commented Nov 22, 2016 •

edited

Loading

Coverage decreased (-1.4%) to 88.889% when pulling fd8262b on crispywalrus:master into 5e202ea on iheartradio:master.

Member

kailuowang commented Nov 23, 2016

Thanks!! Are you sure the tests you wrote run? If I understand correctly the tests methods should be interpolated inside the is string.


          fix tests

1e6a303

turns out I missed putting the interpolated call into the 'is' comprehension.

coveralls commented Nov 23, 2016

Coverage increased (+0.3%) to 90.598% when pulling 1e6a303 on crispywalrus:master into 5e202ea on iheartradio:master.

4 similar comments

coveralls commented Nov 23, 2016

Coverage increased (+0.3%) to 90.598% when pulling 1e6a303 on crispywalrus:master into 5e202ea on iheartradio:master.

coveralls commented Nov 23, 2016

Coverage increased (+0.3%) to 90.598% when pulling 1e6a303 on crispywalrus:master into 5e202ea on iheartradio:master.

coveralls commented Nov 23, 2016

Coverage increased (+0.3%) to 90.598% when pulling 1e6a303 on crispywalrus:master into 5e202ea on iheartradio:master.

coveralls commented Nov 23, 2016 •

edited

Loading

Coverage increased (+0.3%) to 90.598% when pulling 1e6a303 on crispywalrus:master into 5e202ea on iheartradio:master.

Author

crispywalrus commented Nov 23, 2016

@kailuowang Ok, I get it now.

Member

kailuowang commented Nov 23, 2016

👍 thanks very much!

kailuowang merged commit 5609b7f into iheartradio:master

Member

kailuowang commented Nov 23, 2016

how soon do you need this feature release? @crispywalrus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet