Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark _attron function as unsafe #90

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kitcatier
Copy link

@kitcatier kitcatier commented Mar 20, 2023

pub fn _attron(w: WINDOW, attributes: chtype) -> i32 {
unsafe { wattron(w, attributes as NCURSES_ATTR_T) }
}

Hello, this function needs to add the unsafe keyword, because it calls another unverified C function wattron, which is an unsafe operation..

It is not a good choice to mark the entire function body as unsafe, which will make the caller ignore the safety requirements that the function parameters must guarantee, the developer who calls the _attron function may not notice this safety requirement, if a function's entire body is unsafe, the function is itself unsafe and should be marked appropriately

Marking them unsafe also means that callers must make sure they know what they're doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant