Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newterm() to return a Window #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gyscos
Copy link
Contributor

@gyscos gyscos commented Mar 4, 2019

To make newterm useful, we need a way to access the screen object. This can be done through stdscr() (see #43) or by returning a Window from newterm, so that it matches initscr. This PR does the second option.

@insidewhy
Copy link

@gyscos Hi, I need this also. Wondered how/if you worked around it?

@gyscos
Copy link
Contributor Author

gyscos commented Nov 10, 2019

I have not worked around it so far.

This PR currently fails on Windows - I forgot if it ever worked (and something changed), or if I just missed it in the first place.

@TimonPost
Copy link

I would like to see this one merged. There was anything wrong with the windows code? I will have a look for you.

@TimonPost
Copy link

pdcurses function returns a SCREEN while window::new_window expects an WINDOW

   pub fn newterm(arg1: *const ::std::os::raw::c_char,
                   arg2: *mut FILE,
                   arg3: *mut FILE)
                   -> *mut SCREEN;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants