fix: fix warning about yyget_leng returning wrong type when using LTO #676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempt to fix the following errors found by CRAN:
https://www.stats.ox.ac.uk/pub/bdr/LTO/igraph.out
I noticed that this problem does not occur when compiling the C core separately. In fact, it seems that
yyget_leng
should returnint
instead foyy_size_t
.This PR removes the string replacement that was meant to maintain compatibility with the ancient flex version that comes with macOS. Since we now generate parser sources with the latest flex on CI, I think there is no need for this fix anymore.
An alternative would be to avoid doing the replacement for
yyget_leng
.Note: I used the latest flex 2.6.4. for this. Not sure why it generated slightly different line numbers.