Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Avoid submodules for building igraph #674

Merged
merged 5 commits into from
Feb 13, 2023
Merged

chore: Avoid submodules for building igraph #674

merged 5 commits into from
Feb 13, 2023

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Feb 13, 2023

We keep using the submodules, but only as a source of the C files. The process of updating the C core is documented in src/README.md .

@krlmlr krlmlr requested a review from szhorvat February 13, 2023 06:11
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #674 (678d796) into main (438c21d) will not change coverage.
The diff coverage is n/a.

❗ Current head 678d796 differs from pull request most recent head 6d90984. Consider uploading reports for the commit 6d90984 to get more accurate results

@@           Coverage Diff           @@
##             main     #674   +/-   ##
=======================================
  Coverage   60.48%   60.48%           
=======================================
  Files          73       73           
  Lines       21608    21608           
=======================================
  Hits        13070    13070           
  Misses       8538     8538           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@szhorvat
Copy link
Member

Makes sense to me, though @ntamas is much more qualified to comment on this type of thing :-)

```sh
git submodule init
git submodule update
# git submodule magic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this line meant to be left in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could replace it by an example to update to a specific SHA. I'm not familiar with git submodule syntax.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's what you meant. I'll complement this README file later to make that clear, but feel free to merge anytime.

@ntamas ntamas merged commit fd4a242 into main Feb 13, 2023
@ntamas ntamas deleted the f-unsubmodule branch February 13, 2023 09:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants