-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Avoid submodules for building igraph #674
Conversation
Codecov Report
@@ Coverage Diff @@
## main #674 +/- ##
=======================================
Coverage 60.48% 60.48%
=======================================
Files 73 73
Lines 21608 21608
=======================================
Hits 13070 13070
Misses 8538 8538 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Makes sense to me, though @ntamas is much more qualified to comment on this type of thing :-) |
```sh | ||
git submodule init | ||
git submodule update | ||
# git submodule magic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this line meant to be left in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could replace it by an example to update to a specific SHA. I'm not familiar with git submodule
syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's what you meant. I'll complement this README file later to make that clear, but feel free to merge anytime.
We keep using the submodules, but only as a source of the C files. The process of updating the C core is documented in
src/README.md
.