-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Makevars cleanup #671
Conversation
Codecov Report
@@ Coverage Diff @@
## main #671 +/- ##
=======================================
Coverage 60.48% 60.48%
=======================================
Files 73 73
Lines 21608 21608
=======================================
Hits 13070 13070
Misses 8538 8538 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -0,0 +1 @@ | |||
// This file is required so that package installation uses a C++ linker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a link to https://cran.r-project.org/doc/manuals/r-release/R-exts.html#External-C_002b_002b-code in a comment?
Since this is following advice directly from the R manual, I guess it's fine. Please just keep that link to the manual in a comment in the sources. This file is not going to be compiled, so there won't be issues with empty compilation units (which CRAN would complain about). No need for hacks like this. |
This adds a dummy C++ file to ensure that a C++ linker is always selected. Also, we don't need to ship
src/Makevars
.Rationale, from r-exts, https://cran.r-project.org/doc/manuals/r-release/R-exts.html#External-C_002b_002b-code:
This is essentially what we sent to CRAN, plus the dummy C++ file.