Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update stimulus to 0.21.4 #1210

Merged
merged 1 commit into from
Feb 8, 2024
Merged

chore: update stimulus to 0.21.4 #1210

merged 1 commit into from
Feb 8, 2024

Conversation

szhorvat
Copy link
Member

@szhorvat szhorvat commented Feb 6, 2024

This updates Stimulus to the latest version, fixing issues with generating empty argument lists. See igraph/stimulus#6

Once this version is used to re-generate rinterface.c, issues like this will be fixed:

rigraph/src/rinterface.c

Lines 11506 to 11507 in 9cc9560

// FIXME: Change Stimulus to generate (void) instead of ()
SEXP R_igraph_version(void) {

Please do merge this now but do not re-generate the code until #1207 is merged.

@krlmlr OK to add Stimulus updates to the merge queue myself in the future?

Copy link
Contributor

aviator-app bot commented Feb 6, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr
Copy link
Contributor

krlmlr commented Feb 8, 2024

Thanks! The mainline no longer suffers from this problem after you fixed the drift, merging anyway.

@aviator-app aviator-app bot merged commit 647732c into main Feb 8, 2024
14 checks passed
@aviator-app aviator-app bot deleted the chore/stimulus-0.21.4 branch February 8, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants