Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

fix(system): update type hint for html arg #17

Merged
merged 1 commit into from
Apr 14, 2022
Merged

fix(system): update type hint for html arg #17

merged 1 commit into from
Apr 14, 2022

Conversation

cesarcoatl
Copy link
Member

Fixes #16

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When system.net.sendEmail is called and a bool is passed to html, PyCharm produces a warning with the following message:

Expected type 'Union[str, unicode, None]', got 'bool' instead

Issue Number: #16

What is the new behavior?

The correct type hint is now used

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@cesarcoatl cesarcoatl merged commit 7012e4f into ignition-devs:main Apr 14, 2022
@cesarcoatl cesarcoatl deleted the fix/system/typing-sendEmail branch April 14, 2022 22:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant