Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

refactor: improve Version comparison logic #10

Merged
merged 1 commit into from
Mar 22, 2022
Merged

refactor: improve Version comparison logic #10

merged 1 commit into from
Mar 22, 2022

Conversation

cesarcoatl
Copy link
Member

Signed-off-by: César Román thecesrom@gmail.com

Signed-off-by: César Román <thecesrom@gmail.com>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 22, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 3.79%.

Quality metrics Before After Change
Complexity 2.30 ⭐ 0.94 ⭐ -1.36 👍
Method Length 19.48 ⭐ 18.61 ⭐ -0.87 👍
Working memory 4.47 ⭐ 4.24 ⭐ -0.23 👍
Quality 87.67% 91.46% 3.79% 👍
Other metrics Before After Change
Lines 111 89 -22
Changed files Quality Before Quality After Quality Change
src/com/inductiveautomation/ignition/common/model/init.py 87.67% ⭐ 91.46% ⭐ 3.79% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@cesarcoatl cesarcoatl merged commit 0fdb0e4 into ignition-devs:main Mar 22, 2022
@cesarcoatl cesarcoatl deleted the refactor/Version branch March 22, 2022 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant