Documentation: Add documentation for Profile.php #4
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good catch. I agree, will do that in the future. This actually will return a base64 string of an image. Our student portal sending the profile picture as base64 url =3= which is... weird, but well. That being said, please update the return type to string and add more information to other functions too. Thanks! |
|
I updated the PR regarding to your feedback. |
|
Thank you! Adding labels as per https://hacktoberfest.digitalocean.com/hacktoberfest-update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get the correct return type for the getProfilePict_base64(), there is a need of refactoring, since the data type is not 100% clear.
I added it as mixed data.