Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor content of j9ddr.jar into module openj9.dtfjview #380

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Refactor content of j9ddr.jar into module openj9.dtfjview #380

merged 1 commit into from
Jan 26, 2021

Conversation

keithc-ca
Copy link
Member

@keithc-ca keithc-ca commented Jan 21, 2021 •
edited
Loading

  • generate content in gensrc phase
  • expect openj9.dtfj to host ZFile stub class when appropriate

Part of the solution for eclipse-openj9/openj9#11464.
Depends on, and must be merged at the same time as, eclipse-openj9/openj9#11735.

@keithc-ca
Refactor content of j9ddr.jar into module openj9.dtfjview
b3ca917 
* generate content in gensrc phase
* expect openj9.dtfj to host ZFile stub class when appropriate

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca keithc-ca marked this pull request as ready for review January 21, 2021 21:17
@pshipton
Copy link
Member

with the actual Pull Request

jenkins test sanity,extended zlinux jdk11 depends eclipse-openj9/openj9#11735

@pshipton pshipton mentioned this pull request Jan 25, 2021
Merged
@pshipton pshipton merged commit f7475ea into ibmruntimes:openj9 Jan 26, 2021
@keithc-ca keithc-ca deleted the j9ddr branch January 26, 2021 16:56
@knn-k knn-k mentioned this pull request Jan 29, 2021
Open
@knn-k
Copy link
Contributor

knn-k commented Jan 29, 2021 •
edited
Loading

Does this change work with the --disable-ddr option of configure?
AArch64 cross build requires the --disable-ddr option. eclipse-openj9/openj9#8814
Building in native AArch64 environment (with DDR enabled) is OK.
Native build generates the following error when I use --disable-ddr.

make[3]: *** No rule to make target 'all', needed by 'default'.  Stop.
make[2]: *** [make/Main.gmk:112: openj9.dtfj-gensrc-src] Error 2
make[2]: *** Waiting for unfinished jobs....

The generated make-support/main-targets.gmk contains openj9.dtfj-gensrc and similar symbols in its ALL_MAIN_TARGETS.

@keithc-ca
Copy link
Member Author

keithc-ca commented Jan 29, 2021 •
edited by pshipton
Loading

The build failure with --disable-ddr is tracked by eclipse-openj9/openj9#11818. I hope to have a fix today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keithc-ca @pshipton @knn-k