Remove floating UI #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: removes mode subsettings panel
josh-willis-arcadis
requested review from
amy-corson-ibigroup and
daniel-heppner-ibigroup
amy-corson-ibigroup
approved these changes
Jul 16, 2024
amy-corson-ibigroup
assigned daniel-heppner-ibigroup and unassigned amy-corson-ibigroup
daniel-heppner-ibigroup
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Approved as soon as @amy-corson-ibigroup confirms this is the right parent branch
daniel-heppner-ibigroup
assigned josh-willis-arcadis and unassigned daniel-heppner-ibigroup
|
I think so! This will move these changes into opentripplanner#749, which would mean we can merge all of these big changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes floating-ui from metro mode selector. This functionality will be moved to the advanced trip form.