-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: define and document MAP_BASE_URL to prevent gray maps #1016
fix: define and document MAP_BASE_URL to prevent gray maps #1016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great thanks for these changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you just fix the comment for the MAP_BASE_URL
parameter, please?
configurations/default/env.yml.tmp
Outdated
@@ -6,6 +6,7 @@ MAP_BASE_URL: optional-map-tile-url | |||
MAPBOX_ACCESS_TOKEN: your-mapbox-access-token | |||
MAPBOX_MAP_ID: mapbox/outdoors-v11 | |||
MAPBOX_ATTRIBUTION: <a href="https://www.mapbox.com/about/maps/" target="_blank">© Mapbox © OpenStreetMap</a> <a href="https://www.mapbox.com/map-feedback/" target="_blank">Improve this map</a> | |||
MAP_BASE_URL: http://tile.openstreetmap.org/{z}/{x}/{y}.png # Keep it until a fix or maps are gray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment seems incomplete. Could you reword it, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you just fix the comment for the MAP_BASE_URL parameter, please?
Sorry for the delay, I've commented MAP_BASE_URL. |
Checklist
Description
The maps are gray when we start the application with this commit id ae16265.
A functional fix was suggested by a maintainer. My suggestion is to add it to the default environment variables template.
Fix suggestion: #983 (comment)
Related issue: #983