fix: define and document MAP_BASE_URL to prevent gray maps #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
approved these changes
Jul 11, 2024
binh-dam-ibigroup
approved these changes
Jul 16, 2024
configurations/default/env.yml.tmp
Outdated
| @@ -6,6 +6,7 @@ MAP_BASE_URL: optional-map-tile-url | |||
| MAPBOX_ACCESS_TOKEN: your-mapbox-access-token | |||
| MAPBOX_MAP_ID: mapbox/outdoors-v11 | |||
| MAPBOX_ATTRIBUTION: <a href="https://www.mapbox.com/about/maps/" target="_blank">© Mapbox © OpenStreetMap</a> <a href="https://www.mapbox.com/map-feedback/" target="_blank">Improve this map</a> | |||
| MAP_BASE_URL: http://tile.openstreetmap.org/{z}/{x}/{y}.png # Keep it until a fix or maps are gray | |||
There was a problem hiding this comment.
The comment seems incomplete. Could you reword it, please?
binh-dam-ibigroup
requested changes
Jul 16, 2024
|
Sorry for the delay, I've commented MAP_BASE_URL. |
binh-dam-ibigroup
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The maps are gray when we start the application with this commit id ae16265.
A functional fix was suggested by a maintainer. My suggestion is to add it to the default environment variables template.
Fix suggestion: #983 (comment)
Related issue: #983