Fix finnish localization #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason days ended with the letter "o" instead of dots, so "15o [month]". This is incorrect. Source: I'm a native speaker and https://www.kielikello.fi/-/miten-paivamaara-merkitaan-
Codecov Report
@@ Coverage Diff @@
## dev #963 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 169 169
Lines 1429 1429
Branches 305 305
=========================================
Hits 1429 1429
Continue to review full report at Codecov.
|
|
Thanks! Waiting for native speaker code review ( 0 / 2 ) |
dnmr
approved these changes
Jul 22, 2020
|
Cool! Waiting for native speaker code review ( 1 / 2 ) |
|
This is weird issue as well. If I understand correctly issue is with using Do in pattern which is part of Advanced format plugin, but not recognized in this context. |
|
@tarasbobak Since there is already a native speaker code review above, if you've reviewed this PR and think it correct, we can merge it today. |
|
Yes, it looks good. |
|
Great! |
iamkun
pushed a commit
that referenced
this pull request
Sep 17, 2020
## [1.8.36](v1.8.35...v1.8.36) (2020-09-17) ### Bug Fixes * Add Amharic (am) locale ([#1046](#1046)) ([cdc49a1](cdc49a1)) * Export Duration type in duration plugin ([#1043](#1043)) ([0f20c3a](0f20c3a)) * Fix duration plugin parsing milliseconds bug ([#1042](#1042)) ([fe2301b](fe2301b)) * Timezone plugin set default timezone ([#1033](#1033)) ([0c2050a](0c2050a)) * Timezone plugin should have the same behavior in latest ICU version ([#1032](#1032)) ([de31592](de31592)) * Update Finnish (fi) locale ([#963](#963)) ([cf8b6a0](cf8b6a0)) * Update Polish (pl) , Hungarian (hr) and Lithuanian (lt) localization ([#1045](#1045)) ([638fd39](638fd39))
|
🎉 This PR is included in version 1.8.36 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.36](iamkun/dayjs@v1.8.35...v1.8.36) (2020-09-17) ### Bug Fixes * Add Amharic (am) locale ([#1046](iamkun/dayjs#1046)) ([cdc49a1](iamkun/dayjs@cdc49a1)) * Export Duration type in duration plugin ([#1043](iamkun/dayjs#1043)) ([0f20c3a](iamkun/dayjs@0f20c3a)) * Fix duration plugin parsing milliseconds bug ([#1042](iamkun/dayjs#1042)) ([fe2301b](iamkun/dayjs@fe2301b)) * Timezone plugin set default timezone ([#1033](iamkun/dayjs#1033)) ([0c2050a](iamkun/dayjs@0c2050a)) * Timezone plugin should have the same behavior in latest ICU version ([#1032](iamkun/dayjs#1032)) ([de31592](iamkun/dayjs@de31592)) * Update Finnish (fi) locale ([#963](iamkun/dayjs#963)) ([cf8b6a0](iamkun/dayjs@cf8b6a0)) * Update Polish (pl) , Hungarian (hr) and Lithuanian (lt) localization ([#1045](iamkun/dayjs#1045)) ([638fd39](iamkun/dayjs@638fd39))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.36](iamkun/dayjs@v1.8.35...v1.8.36) (2020-09-17) ### Bug Fixes * Add Amharic (am) locale ([#1046](iamkun/dayjs#1046)) ([cdc49a1](iamkun/dayjs@cdc49a1)) * Export Duration type in duration plugin ([#1043](iamkun/dayjs#1043)) ([0f20c3a](iamkun/dayjs@0f20c3a)) * Fix duration plugin parsing milliseconds bug ([#1042](iamkun/dayjs#1042)) ([fe2301b](iamkun/dayjs@fe2301b)) * Timezone plugin set default timezone ([#1033](iamkun/dayjs#1033)) ([0c2050a](iamkun/dayjs@0c2050a)) * Timezone plugin should have the same behavior in latest ICU version ([#1032](iamkun/dayjs#1032)) ([de31592](iamkun/dayjs@de31592)) * Update Finnish (fi) locale ([#963](iamkun/dayjs#963)) ([cf8b6a0](iamkun/dayjs@cf8b6a0)) * Update Polish (pl) , Hungarian (hr) and Lithuanian (lt) localization ([#1045](iamkun/dayjs#1045)) ([638fd39](iamkun/dayjs@638fd39))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason days ended with the letter "o" instead of dots, so "15o [month]".
This is incorrect.
Source: I'm a native speaker and https://www.kielikello.fi/-/miten-paivamaara-merkitaan-