Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix QuarterOfYear plugin bug #591

Merged
merged 1 commit into from
May 7, 2019
Merged

fix: Fix QuarterOfYear plugin bug #591

merged 1 commit into from
May 7, 2019

Conversation

iamkun
Copy link
Owner

@iamkun iamkun commented May 7, 2019

fix #587


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@codecov-io
Copy link

codecov-io commented May 7, 2019

Codecov Report

Merging #591 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #591   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       154    154           
  Lines       983    983           
  Branches    140    140           
===================================
  Hits        983    983
Impacted Files Coverage Δ
src/plugin/quarterOfYear/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de14682...f7b6ec8. Read the comment docs.

@iamkun iamkun merged commit 434f774 into dev May 7, 2019
iamkun pushed a commit that referenced this pull request May 7, 2019
## [1.8.14](v1.8.13...v1.8.14) (2019-05-07)

### Bug Fixes

* Fix `.format` API returns UTC offset when value is 0 bug ([b254964](b254964))
* Fix QuarterOfYear plugin bug ([#591](#591)) ([434f774](434f774))
* Fix UTC plugin add day DST bug ([#590](#590)) ([86cd839](86cd839))
@iamkun
Copy link
Owner Author

iamkun commented May 7, 2019

🎉 This PR is included in version 1.8.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label May 7, 2019
@iamkun iamkun deleted the fix/quarter branch September 18, 2019 09:24
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.14](iamkun/dayjs@v1.8.13...v1.8.14) (2019-05-07)

### Bug Fixes

* Fix `.format` API returns UTC offset when value is 0 bug ([b254964](iamkun/dayjs@b254964))
* Fix QuarterOfYear plugin bug ([#591](iamkun/dayjs#591)) ([434f774](iamkun/dayjs@434f774))
* Fix UTC plugin add day DST bug ([#590](iamkun/dayjs#590)) ([86cd839](iamkun/dayjs@86cd839))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.14](iamkun/dayjs@v1.8.13...v1.8.14) (2019-05-07)

### Bug Fixes

* Fix `.format` API returns UTC offset when value is 0 bug ([b254964](iamkun/dayjs@b254964))
* Fix QuarterOfYear plugin bug ([#591](iamkun/dayjs#591)) ([434f774](iamkun/dayjs@434f774))
* Fix UTC plugin add day DST bug ([#590](iamkun/dayjs#590)) ([86cd839](iamkun/dayjs@86cd839))
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this pull request Sep 12, 2024
## [1.8.14](iamkun/dayjs@v1.8.13...v1.8.14) (2019-05-07)

### Bug Fixes

* Fix `.format` API returns UTC offset when value is 0 bug ([7f25195](iamkun/dayjs@7f25195))
* Fix QuarterOfYear plugin bug ([#591](iamkun/dayjs#591)) ([3ce1eab](iamkun/dayjs@3ce1eab))
* Fix UTC plugin add day DST bug ([#590](iamkun/dayjs#590)) ([551e15f](iamkun/dayjs@551e15f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarter() difference from Moment
2 participants