Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix declaration file #496

Merged
merged 1 commit into from
Feb 18, 2019
Merged

fix: fix declaration file #496

merged 1 commit into from
Feb 18, 2019

Conversation

huihuimoe
Copy link
Contributor

fix d.ts file for #74

const that = dayjs(input)

dayjs/src/index.js

Lines 98 to 109 in 56050c2

isSame(that, units) {
const other = dayjs(that)
return this.startOf(units) <= other && other <= this.endOf(units)
}
isAfter(that, units) {
return dayjs(that) < this.startOf(units)
}
isBefore(that, units) {
return this.endOf(units) < dayjs(that)
}

@codecov-io
Copy link

codecov-io commented Feb 15, 2019

Codecov Report

Merging #496 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #496   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        58     58           
  Lines       509    509           
  Branches     83     83           
===================================
  Hits        509    509

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56050c2...fc959bb. Read the comment docs.

@iamkun iamkun merged commit 4523275 into iamkun:dev Feb 18, 2019
iamkun pushed a commit that referenced this pull request Feb 24, 2019
## [1.8.7](v1.8.6...v1.8.7) (2019-02-24)

### Bug Fixes

* Add plugin type definitions ([#418](#418)) ([361d437](361d437))
* Add Swahili locale ([#508](#508)) ([b9cee84](b9cee84))
* Parse month string 'MMMM MMM (February, Feb)' in customParseFormat ([#457](#457)) ([f343206](f343206))
* Update declaration file .diff .isBefore .isSame .isAfter ([#496](#496)) ([4523275](4523275))
* Word orders corrections for locale 'fa' ([#491](#491)) ([56050c2](56050c2))
@iamkun
Copy link
Owner

iamkun commented Feb 24, 2019

🎉 This PR is included in version 1.8.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.7](iamkun/dayjs@v1.8.6...v1.8.7) (2019-02-24)

### Bug Fixes

* Add plugin type definitions ([#418](iamkun/dayjs#418)) ([361d437](iamkun/dayjs@361d437))
* Add Swahili locale ([#508](iamkun/dayjs#508)) ([b9cee84](iamkun/dayjs@b9cee84))
* Parse month string 'MMMM MMM (February, Feb)' in customParseFormat ([#457](iamkun/dayjs#457)) ([f343206](iamkun/dayjs@f343206))
* Update declaration file .diff .isBefore .isSame .isAfter ([#496](iamkun/dayjs#496)) ([4523275](iamkun/dayjs@4523275))
* Word orders corrections for locale 'fa' ([#491](iamkun/dayjs#491)) ([56050c2](iamkun/dayjs@56050c2))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.7](iamkun/dayjs@v1.8.6...v1.8.7) (2019-02-24)

### Bug Fixes

* Add plugin type definitions ([#418](iamkun/dayjs#418)) ([361d437](iamkun/dayjs@361d437))
* Add Swahili locale ([#508](iamkun/dayjs#508)) ([b9cee84](iamkun/dayjs@b9cee84))
* Parse month string 'MMMM MMM (February, Feb)' in customParseFormat ([#457](iamkun/dayjs#457)) ([f343206](iamkun/dayjs@f343206))
* Update declaration file .diff .isBefore .isSame .isAfter ([#496](iamkun/dayjs#496)) ([4523275](iamkun/dayjs@4523275))
* Word orders corrections for locale 'fa' ([#491](iamkun/dayjs#491)) ([56050c2](iamkun/dayjs@56050c2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants