Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ja document of i18n #183

Merged
merged 1 commit into from
May 21, 2018
Merged

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented May 21, 2018

@iamkun

To reflect this change: #182 (comment)

@codecov-io
Copy link

codecov-io commented May 21, 2018

Codecov Report

Merging #183 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #183   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines         275    275           
  Branches       47     47           
=====================================
  Hits          275    275

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be4493...8ebf447. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented May 21, 2018

Quick reaction! THX.

One more question, do you have any good experience about keeping the translated docs up to date with the english one? My might need something in the coming future.

@iamkun iamkun merged commit 00acd63 into iamkun:master May 21, 2018
@ohbarye ohbarye deleted the update-ja-doc-of-i18n branch May 21, 2018 03:45
@ohbarye
Copy link
Contributor Author

ohbarye commented May 21, 2018

Well, sorry, I have no idea.

(I use https://webtranslateit.com/ while developing an international product in my job. But I assume that's not for document maintenance.)

@iamkun
Copy link
Owner

iamkun commented May 21, 2018

We'll keep looking thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants