Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: valueOf not correct when cross summertime #1819

Closed
wants to merge 1 commit into from

Conversation

huoyuxin
Copy link

@huoyuxin huoyuxin commented Mar 3, 2022

eg:

  • system timezone Europe/Warsaw

  • system date 2022-03-01

dayjs.tz.setDefault('Europe/Warsaw')
dayjs.tz().endOf('month').valueOf() -> 1648760399999, it should be 1648763999999

eg: system timezone Europe/Warsaw, system date 2022-03-01
dayjs.tz.setDefault('Europe/Warsaw')
dayjs.tz().endOf('month').valueOf()  -> 1648760399999,  it should be 1648763999999
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1819 (95dccac) into dev (dcbf170) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev     #1819   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          180       180           
  Lines         2034      2034           
  Branches       524       524           
=========================================
  Hits          2034      2034           
Impacted Files Coverage Δ
src/plugin/utc/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcbf170...95dccac. Read the comment docs.

@xvaara
Copy link
Contributor

xvaara commented Mar 19, 2022

this is same as #1448
but since it's a year old and not merged (even though it's a big problem), one has to wonder where to focus of this project is.

@huoyuxin
Copy link
Author

this is same as #1448 but since it's a year old and not merged (even though it's a big problem), one has to wonder where to focus of this project is.

does it mean that mr will not be merged, and summertime users like me can only fixed it in project ..

@iamkun
Copy link
Owner

iamkun commented May 3, 2022

Thanks, fixed in #1448

@iamkun iamkun closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants