fix: remove module entry in package.json #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1314 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 175 175
Lines 1697 1697
Branches 387 387
=========================================
Hits 1697 1697 Continue to review full report at Codecov.
|
iamkun
pushed a commit
that referenced
this pull request
Jan 5, 2021
## [1.10.2](v1.10.1...v1.10.2) (2021-01-05) ### Bug Fixes * fix parse regex bug ([#1307](#1307)) ([db2b6a5](db2b6a5)), closes [#1305](#1305) * remove module entry in package.json to revert 1.10.1 change ([#1314](#1314)) ([824dcb8](824dcb8)) * update devHelper add warning "passing Year as a Number will be parsed as a Unix timestamp" ([#1315](#1315)) ([b0dda31](b0dda31))
|
🎉 This PR is included in version 1.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 16, 2021
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.10.2](iamkun/dayjs@v1.10.1...v1.10.2) (2021-01-05) ### Bug Fixes * fix parse regex bug ([#1307](iamkun/dayjs#1307)) ([db2b6a5](iamkun/dayjs@db2b6a5)), closes [#1305](iamkun/dayjs#1305) * remove module entry in package.json to revert 1.10.1 change ([#1314](iamkun/dayjs#1314)) ([824dcb8](iamkun/dayjs@824dcb8)) * update devHelper add warning "passing Year as a Number will be parsed as a Unix timestamp" ([#1315](iamkun/dayjs#1315)) ([b0dda31](iamkun/dayjs@b0dda31))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.10.2](iamkun/dayjs@v1.10.1...v1.10.2) (2021-01-05) ### Bug Fixes * fix parse regex bug ([#1307](iamkun/dayjs#1307)) ([db2b6a5](iamkun/dayjs@db2b6a5)), closes [#1305](iamkun/dayjs#1305) * remove module entry in package.json to revert 1.10.1 change ([#1314](iamkun/dayjs#1314)) ([824dcb8](iamkun/dayjs@824dcb8)) * update devHelper add warning "passing Year as a Number will be parsed as a Unix timestamp" ([#1315](iamkun/dayjs#1315)) ([b0dda31](iamkun/dayjs@b0dda31))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1281
This change in 1.10.1 add ES6 Module Support, package.json module point to "esm/index.js" (#1298) (f63375d)
really has an unexpected breaking change, and that's of course not what we want.
I am planning to revert this change in the next release 1.10.2 and delete the "module" entry.
Besides, maybe there's no need for Day.js to support ESM bundle, this would only introduce some conflict but no benefits in the tree shaking. A better way might be a separate npm package (like "dayjs-esm") to ship an ESM package.