Differences to moment?

[flosse]

Could you add a section to the README.md that explains the differences to moment? Why is it faster/smaller? What features are missing? Are the parts of the API that are different? What was your motivation to "reinvent" the wheel?

[ghost]

+1

[perrupa]

This is probably going to be the question front of mind for most people considering DayJS: Why DayJS instead of MomentJS?

Personally, my team is moving away from moment and I'd like to know what tradeoffs I'd be making by choosing DayJS and if it meets my needs or not (eg: timezones or i18n concerns).

Either way, best of luck. This looks like an incredible project! 👍

[iamkun]

Will do

[acrazing]

Is dayjs fully compatible with moment? I hope to use alias in webpack to replace moment with dayjs, but I cannot ensure if it is ok to do it. Is there any guidelines?

[naulacambra]

There are some functions that are not yet implemented, and others are available through plugins. Try to change the alias, and see if everything works fine

[acrazing]

Well, I found the second argument of Dayjs#diff is different, it accepts singular but Moment#diff accepts plural.

[ghost]

@acrazing Dayjs accepts both I think

[acrazing]

@xxyuk um.. I use typescript to check it, its singular only and is required in index.d.ts: https://github.com/iamkun/dayjs/blob/master/index.d.ts#L57

[ghost]

Oh I see.

We might could update it like this ? I'm not sure

export type UnitType = 'millisecond' | 'milliseconds' | 'second' | 'seconds' | 'minute' | 'minutes' | 'hour' | 'day' | 'week' | 'month' | 'quarter' | 'year' | 'date'

But I'm not good with TS, anyone could send a PR to fix this?

[zediah]

One thing I've just come across that's different is Moment accepts an array on constructor - e.g. moment([2018, 1, 1]) but dayjs doesn't seem to know how to parse this.

[ghost]

@zediah Yes, Day.js can't parse array or object at this time.

[ghost]

https://github.com/you-dont-need/You-Dont-Need-Momentjs

Here is a simple comparison between Day.js, Moment.js, Luxon, Native Date and Date-fns.

[sandstrom]

Would also be good if the readme mentioned Luxon, which is an immutable moment-js descendent.

[niftylettuce]

It looks like all of these Get + Set functions are missing from dayjs, even with all plugins enabled https://momentjs.com/docs/#/get-set/

[ghost]

@niftylettuce may be you are wrong.

[niftylettuce]

@xxyuk correct, I am wrong in the sense that the plural versions are not available, https://github.com/iamkun/dayjs/blob/dev/docs/en/API-reference.md#get-and-set, e.g. hour() exists but not its alias hours(). just discovered this.

[iamkun]

Please see #58 (comment)