fix: timezone plugin should have the same behavior in latest ICU v… #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1032 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 171 171
Lines 1488 1490 +2
Branches 315 316 +1
=========================================
+ Hits 1488 1490 +2
Continue to review full report at Codecov.
|
|
THX |
iamkun
pushed a commit
that referenced
this pull request
Sep 17, 2020
## [1.8.36](v1.8.35...v1.8.36) (2020-09-17) ### Bug Fixes * Add Amharic (am) locale ([#1046](#1046)) ([cdc49a1](cdc49a1)) * Export Duration type in duration plugin ([#1043](#1043)) ([0f20c3a](0f20c3a)) * Fix duration plugin parsing milliseconds bug ([#1042](#1042)) ([fe2301b](fe2301b)) * Timezone plugin set default timezone ([#1033](#1033)) ([0c2050a](0c2050a)) * Timezone plugin should have the same behavior in latest ICU version ([#1032](#1032)) ([de31592](de31592)) * Update Finnish (fi) locale ([#963](#963)) ([cf8b6a0](cf8b6a0)) * Update Polish (pl) , Hungarian (hr) and Lithuanian (lt) localization ([#1045](#1045)) ([638fd39](638fd39))
|
🎉 This PR is included in version 1.8.36 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Should not it need a test for future regression? |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.36](iamkun/dayjs@v1.8.35...v1.8.36) (2020-09-17) ### Bug Fixes * Add Amharic (am) locale ([#1046](iamkun/dayjs#1046)) ([cdc49a1](iamkun/dayjs@cdc49a1)) * Export Duration type in duration plugin ([#1043](iamkun/dayjs#1043)) ([0f20c3a](iamkun/dayjs@0f20c3a)) * Fix duration plugin parsing milliseconds bug ([#1042](iamkun/dayjs#1042)) ([fe2301b](iamkun/dayjs@fe2301b)) * Timezone plugin set default timezone ([#1033](iamkun/dayjs#1033)) ([0c2050a](iamkun/dayjs@0c2050a)) * Timezone plugin should have the same behavior in latest ICU version ([#1032](iamkun/dayjs#1032)) ([de31592](iamkun/dayjs@de31592)) * Update Finnish (fi) locale ([#963](iamkun/dayjs#963)) ([cf8b6a0](iamkun/dayjs@cf8b6a0)) * Update Polish (pl) , Hungarian (hr) and Lithuanian (lt) localization ([#1045](iamkun/dayjs#1045)) ([638fd39](iamkun/dayjs@638fd39))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.36](iamkun/dayjs@v1.8.35...v1.8.36) (2020-09-17) ### Bug Fixes * Add Amharic (am) locale ([#1046](iamkun/dayjs#1046)) ([cdc49a1](iamkun/dayjs@cdc49a1)) * Export Duration type in duration plugin ([#1043](iamkun/dayjs#1043)) ([0f20c3a](iamkun/dayjs@0f20c3a)) * Fix duration plugin parsing milliseconds bug ([#1042](iamkun/dayjs#1042)) ([fe2301b](iamkun/dayjs@fe2301b)) * Timezone plugin set default timezone ([#1033](iamkun/dayjs#1033)) ([0c2050a](iamkun/dayjs@0c2050a)) * Timezone plugin should have the same behavior in latest ICU version ([#1032](iamkun/dayjs#1032)) ([de31592](iamkun/dayjs@de31592)) * Update Finnish (fi) locale ([#963](iamkun/dayjs#963)) ([cf8b6a0](iamkun/dayjs@cf8b6a0)) * Update Polish (pl) , Hungarian (hr) and Lithuanian (lt) localization ([#1045](iamkun/dayjs#1045)) ([638fd39](iamkun/dayjs@638fd39))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 14 use new ICU rules: nodejs/node#33027 which will cause the timezone plugin testing failed.
The behavior should be the same in different node version.