New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not extract enumeration types. #10

Merged

iamazeem merged 1 commit into main from do-not-extract-enumeration-types

Sep 16, 2023

Owner

iamazeem commented Sep 16, 2023

Skip enumeration types while extracting.
- A user may erroneously use an enum type which currently doesn't support msgclass method.
- Calling msgclass on an enum type would break the code.
- Observed and fixed under Fix msg not found error. fluent-plugin-protobuf-http#13.

Signed-off-by: Azeem Sajid azeem.sajid@gmail.com


          Do not extract enumeration types.

ed22846

iamazeem added the enhancement label

iamazeem self-assigned this

iamazeem merged commit eb44e6e into main

3 checks passed

iamazeem deleted the do-not-extract-enumeration-types branch

September 16, 2023 07:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment