-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): bump django-allauth
to 0.62.1
#627
base: master
Are you sure you want to change the base?
Conversation
Done in 3342e05. Where our changes diverge, I went with yours - that is: modified dj_rest_auth/tests/test_serializers.py
@@ -120,10 +120,7 @@ class TestSocialLoginSerializer(TestCase):
def setUpTestData(cls):
cls.request_data = {"access_token": "token1234"}
cls.request = APIRequestFactory().post(cls.request_data, format='json')
-
- middleware = SessionMiddleware(get_response=MagicMock())
- middleware(cls.request)
-
+ cls.request.session = {}
social_app = SocialApp.objects.create(
provider='facebook',
name='Facebook',
@@ -153,7 +150,7 @@ class TestSocialLoginSerializer(TestCase):
serializer.is_valid()
self.assertDictEqual(serializer.errors, self.NO_ADAPTER_CLASS_PRESENT)
- @patch('allauth.socialaccount.providers.facebook.views.FacebookOAuth2Adapter.complete_login')
+ @patch('allauth.socialaccount.providers.facebook.flows.complete_login')
@patch('allauth.socialaccount.adapter.DefaultSocialAccountAdapter.pre_social_login')
def test_immediate_http_response_error(self, mock_pre_social_login, mock_fb_complete_login):
dummy_view = SocialLoginView() All tests pass on 3342e05. |
@gekoke We also need this change: pennersr@4f6ca76 -- for the upcoming new allauth headless functionality several internals to which dj-rest-auth hooks up are changed. |
Anything we can do to help expedite this PR? |
willing to help as well. |
Merged in latest changes and fixed linting error, but there are still some failing tests related to dependencies. |
Bumps tests to support
django-allauth
0.62.1.Also fixes some incidental test breakages that came with the version bump.
Fixes #626.