Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parentheses in SIOTrack.java #191

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix: parentheses in SIOTrack.java #191

merged 1 commit into from
Jun 24, 2024

Conversation

wdconinc
Copy link
Contributor

Fixes https://gitlab.spack.io/spack/spack/-/jobs/11656362

BEGINRELEASENOTES

  • fix: parentheses in SIOTrack.java

ENDRELEASENOTES

@wdconinc
Copy link
Contributor Author

@tmadlener Introduced in #147. Not verified by compilation that this is a complete fix but I think it is.

tmadlener
tmadlener approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, we also didn't test this, but this definitely looks better. Is anyone on your side still using java bindings?

@tmadlener tmadlener merged commit db0b8f6 into iLCSoft:master Jun 24, 2024
10 checks passed
@wdconinc
Copy link
Contributor Author

Is anyone on your side still using java bindings?

Not using java bindings nor lcio. But it showed up as a failure in a spack pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wdconinc @tmadlener