Clear presence on window loses focus, in unsupported page, and when idling w/ window focus. #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the `extension.ts` file to add functionality for clearing the activity when the window loses focus. It introduces two new configuration options: `discord.clearOnIdleWhenInFocus` and `discord.clearOnLoseFocus`, which control whether the activity should be cleared when the editor is in focus during idle time and when the window loses focus, respectively.
lettucegoblin
changed the title
This commit refactors the `extension.ts` file to improve the handling of activity updates and introduces idle timeout functionality. It adds the `handleIdle` function to handle activity clearing based on window focus and idle time. It also introduces the `inputPollingRate` constant to control the rate at which activity is sent when there are text editor changes. Additionally, it modifies the `sendActivity` function to use `await` when setting the activity state. This commit aims to improve the overall performance and user experience of the extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Considered idling when in non-accounted for workspaces(settings page, any file extension not supported yet)
Solution: Clear presence and release control.
Problem: The extension right now rarely lets go of rpc control. If another RPC based app is running(i.e spotify) it would rarely get the chance to show on discord.
Solution: New configuration options:
discord.clearOnIdleWhenInFocusanddiscord.clearOnLoseFocus, which control whether the activity should be cleared when the editor is in focus during idle time and when the window loses focus, respectively.