refactor: remove unneeded object

[SCjona]

Minor optimizations

Works by switching to useState(() => initialValue) and setState((prevState) => nextState)

Checklist

• only relevant code is changed (make a diff before you submit the PR)
• run tests npm run test
• tests are included
• documentation is changed or added

[coveralls]

Coverage remained the same at 96.205% when pulling 740c4e3 on TQjona:master into ffbe35e on i18next:master.

[jamuhl]

Will now unneeded -> does it make a difference?

[SCjona]

This saves a few bytes (~16) in bundle size and some heap memory (approx. 64 bytes per element using useTranslation) due to the object being removed. Theoretically you should also get better performance due to less references on the heap (less work for the garbage collector) and less operations in the JS code, but in the real world those improvements are too small to measure. React can't even handle the amount of elements required to make this effect visible.

I'd still consider merging the PR due to the widespread use of this library, although I wouldn't create an extra release with just this small change.

[adrai]

what was the reason for this comment?

[SCjona]

I assume the original author of the code just tried useState(getT()) with getT() returning the i18n.t function. React detected that the parameter passed to useState was a function and thought it was a lazy-init function (useState(() => initialValue)). So it was calling i18n.t with no args and used the return value as initial value, which was probably null or undefined.

Basically to store a function in a state you have to have a function which returns the function, e.g. useState(() => (args) => console.log(args)) and setState(() => (args) => console.log(args))

[adrai]

lgtm

[jamuhl]

thank you...was published in react-i18next@11.8.12