Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow user provided affixes to be used without providing localeStructure #2100

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

jamsinclair
Copy link
Contributor

@jamsinclair jamsinclair commented Feb 28, 2023

Fixes #2099

As always, thanks for your hard work on this open source library. It's been an amazing benefit, many kudos 🙇

This PR updates the library to allow interpolation affixes to be configured without setting the localeStructure field. This will improve developer experience and simplify user defined config.

If a manual localeStructure is provided, the user will need to ensure it conforms to their custom affixes.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@adrai adrai merged commit 37a203f into i18next:master Feb 28, 2023
@adrai
Copy link
Member

adrai commented Feb 28, 2023

thank you for your awesome contribution...
it's included in v13.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting interpolation prefix and/or suffix causes namespace resolution error
2 participants