Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align with nextjs i18n config types #2057

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Conversation

belgattitude
Copy link
Contributor

Add missging properties to to i18n user config. That aligns with latest nextjs types.

Will fix: #2049

@belgattitude belgattitude self-assigned this Dec 12, 2022
@belgattitude
Copy link
Contributor Author

@adrai IMHO safe to merge (and I'll do) but regarding release 13.0.1 .... I feel it's good to focus on this i18next/i18next#1881 because we'll have bug reports about it.

My time is very short, but I'll try to check in a couple of days. Have a great day

@belgattitude belgattitude merged commit b2ef1bd into master Dec 12, 2022
@belgattitude belgattitude deleted the fix-nextjs-i18n-typings branch December 12, 2022 09:09
@adrai
Copy link
Member

adrai commented Dec 12, 2022

lgtm if this fixes the issue

@belgattitude
Copy link
Contributor Author

I hope so 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set localeDetection in the next-i18next.config
2 participants