Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples should use git install (do not merge) #2003

Closed

Conversation

belgattitude
Copy link
Contributor

When working on #1998 and #1997, I feel it's useful to be able to test from the git build rather than installing the published version (possibly old)

IMHO, we should move out from npm to yarn 3+ or pnpm 7+ and rework the directory structure. Why ? Npm and workspaces aren't yet there when we have to deal with monorepos (ie: workspace protocol rather than files, versioning, isolation...).

@belgattitude
Copy link
Contributor Author

belgattitude commented Nov 6, 2022

I'm investigating this

../../dist/commonjs/serverSideTranslations.js
Critical dependency: the request of a dependency is an expression

Import trace for requested module:
../../dist/commonjs/serverSideTranslations.js
../../serverSideTranslations.js

Related:

and

Error occurred prerendering page "/en". Read more: https://nextjs.org/docs/messages/prerender-error
Error: Cannot find module '/home/sebastien/github/next-i18next/examples/simple/next-i18next.config.js'

Current hack -> To make it work I had to provide the UserConfig. Sched some light on some older problems regarding config location in monorepos. See #1917 (comment) and particulary how I fixed the issue in https://github.com/bryantobing12/layout-reproduce-i18next/pull/1/files#diff-b09c1f3451013e7a5ceffec2636d3175563b96a911a9a91c1fe08d5110a7a1b0

@belgattitude belgattitude changed the title Examples should use git install Examples should use git install (do not merge) Nov 6, 2022
@belgattitude
Copy link
Contributor Author

belgattitude commented Nov 6, 2022

@adrai I won't probably put more work on it in its current form. But it was interesting. The reason why I investigated this:

  • I'd like to ensure that we can catch earlier bugs in publishing and give more confidence when reworking the repo

And seeing cypress build fails... I feel there's issue in the current master.

image

@belgattitude
Copy link
Contributor Author

@adrai If you postpone the next release (v13)... There's actually something wrong, I'll get it sorted out. Reproduced in belgattitude/nextjs-monorepo-example#2864 (inline with what cypress gives in this P/R).

@belgattitude
Copy link
Contributor Author

Closed in favour of #2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant