Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only import default config if no userConfig is passed #1302

Merged
merged 2 commits into from
Jul 6, 2021
Merged

fix: only import default config if no userConfig is passed #1302

merged 2 commits into from
Jul 6, 2021

Conversation

adrai
Copy link
Member

@adrai adrai commented Jul 6, 2021 •
edited by isaachinman

Fixes #1202

@vercel
Copy link

vercel bot commented Jul 6, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/isaachinman/next-i18next/DsYpQgGYtB6vTzc3MG3LWAG1HJEB
✅ Preview: https://next-i18next-git-fork-adrai-patch-1-isaachinman.vercel.app

@adrai adrai changed the title only import default config if no userConfig is passed fix: only import default config if no userConfig is passed Jul 6, 2021
@isaachinman
Copy link
Contributor

Would be great to add a test if you don't mind?

@isaachinman isaachinman merged commit 28cd9c6 into i18next:master Jul 6, 2021
This was referenced Sep 4, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaachinman isaachinman isaachinman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not working with Next.js >= 10.2.x (probably because of webpack 5, dynamic imports are handled differently)
2 participants
@adrai @isaachinman