Stop marker event propagation in order to prevent onPress for MapView…

…s from being called when a marker is clicked. This makes the behavior of Apple Maps identical to that of the behavior of Google Maps on Android. This fixes react-native-maps#1132.
hysan · Mar 7, 2018 · 882d1ce · 882d1ce
1 parent 8f7bd9e
commit 882d1ce
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/lib/components/MapMarker.js b/lib/components/MapMarker.js
@@ -226,10 +226,6 @@ const propTypes = {
   onDragEnd: PropTypes.func,
 };
 
-const defaultProps = {
-  onPress() {},
-};
-
 class MapMarker extends React.Component {
   constructor(props) {
     super(props);
@@ -295,13 +291,18 @@ class MapMarker extends React.Component {
         {...this.props}
         image={image}
         style={[styles.marker, this.props.style]}
+        onPress={event => {
+          event.stopPropagation();
+          if (this.props.onPress) {
+            this.props.onPress(event);
+          }
+        }}
       />
     );
   }
 }
 
 MapMarker.propTypes = propTypes;
-MapMarker.defaultProps = defaultProps;
 MapMarker.viewConfig = viewConfig;
 
 const styles = StyleSheet.create({