execute .env.leave file when leaving a directory #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chunyang-wen Can you change the format to match current file. |
|
@Gnouc What do you mean? It has no conflicts. |
|
@chunyang-wen Using tab instead of spaces. |
|
@Gnouc As you wish. |
|
Please help to decide whether this PR should be merged. If not, please close this PR. Thanks in advance. |
cuonglm
reviewed
Oct 11, 2017
activate.sh
Outdated
|
|
||
| autoenv_init() { | ||
|
|
||
| if [ ! -z $AUTOENV_ENABLE_LEAVE ]; then |
There was a problem hiding this comment.
! -zshould be-nfor simple.$AUTOENV_ENABLE_LEAVEmust be double quotes"$AUTOENV_ENABLE_LEAVE". Variables should always be quoted in shell scripts, except you wantsplit+glob.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with virtualenv, we can source .env file when entering a directory and activate an environment. But when leaving it, it will not be automatically deactivated. This implementation provides a solution, it will source .env.leave file when leaving working directory. But it also contains issues, such as when entering an environment, we cannot enter subdirectories, because it will be automatically deactivated( We are LEAVING current working directory), but we can also put additional .env file under those directories.