-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove javafx exception #990
Merged
iikirilov
merged 3 commits into
hyperledger:master
from
iikirilov:remove_javafx_exception
Aug 18, 2019
Merged
remove javafx exception #990
iikirilov
merged 3 commits into
hyperledger:master
from
iikirilov:remove_javafx_exception
Aug 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-richardson
approved these changes
Aug 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all fine. LGTM.
xaviarias
added a commit
that referenced
this pull request
Aug 26, 2019
* Extract encoding implementation using Java SPI mechanism * Add protected method to allow overriding ENS name resolution * Add hash function for any algorithm and Blake2b-256 implementation * Fix checkstyle errors * Add support for primitive Java types * Fix checkstyle * Add constant modifier to generate return types * Add address length flag and fix dynamic bytes wrapper type bug * Fix checkstyle * Fix checkstyle * Format consistently with other ABI test files * Optimize import * Fix name typo * Fix condition to match address parameter spec * Remove CLI option to avoid user being confused with an extra parameter * Change method visibility to allow specialization * Change method visibility to prevent calling non-static methods * Implement SPI for function decoding * Add bit size getter on NumericType * Make BytesType abstract for consistency with datatype model * Remove redundant Boolean primitive type overlapping with Solidity bool * Avoid loading ABI definitions twice * Add boolean primitive type support * Add support to ENS resolver and contract class injection * Fix indentation and simplify code * Make ENS constant public for re-usability * Revert function signature generating error for 2D arrays * Make method encoding functions protected in superclass so can be reused * Mahe default encoder and decoder public to allow overrides * Pass constructor flag as a parameter on deployment * Pass constructor flag as a parameter on deployment * Add generateSendTxForCalls flag to duplicate send/calls * Fix broken unit test * Fix checkstyle error * Fix test unit after removing method throwing runtime exception * Fix checkstyle error * Add optional contract name in constructor * Extract encoding implementation using Java SPI mechanism * Add hash function for any algorithm and Blake2b-256 implementation * Fix checkstyle errors * Add support for primitive Java types * Change method visibility to prevent calling non-static methods * Remove redundant Boolean primitive type overlapping with Solidity bool * Make method encoding functions protected in superclass so can be reused * Mahe default encoder and decoder public to allow overrides * Fix broken unit test * Fix checkstyle error * Fix test unit after removing method throwing runtime exception * Fix checkstyle error * Make generator constructors public for other plugins * Make generate functions public for other plugins * Add CLI options for contract name and address length to avoid coupling * Apply Spotless formatting to merged files * Remove duplicated method in merge * Fix test by declaring exception * Add constructor parameter * Fix Bytes type resolution and apply BaseEventResponse changes * Remove CHECKSTYLE comments * Update abi/src/main/java/org/web3j/abi/datatypes/Address.java Co-Authored-By: Ivaylo Kirilov <iikirilov@gmail.com> * Update abi/src/main/java/org/web3j/abi/FunctionReturnDecoder.java Co-Authored-By: Ivaylo Kirilov <iikirilov@gmail.com> * Update abi/src/main/java/org/web3j/abi/spi/FunctionDecoderProvider.java Co-Authored-By: Ivaylo Kirilov <iikirilov@gmail.com> * Move comment to Ethereum decoder * Cleanup code by using fields instead of parameters * Restrict bounds of type T to Comparable and Serializable * Fix renaming FunctionReturnDecoder and FunctionReturnDecoderProvider * remove javafx exception (#990) * remove javafx exception * remove javafx exception * spotless * replaces #922 (#997) * added makeTypeReference(), instantiateType(), encodeFunction(), tests * style formatting cleanup * multi-dimensional array test * instantiateType("address", value) accepts BigInteger and Uint160 * formatting * removed try/catch from tests, formatting changes, encodeFunction renamed makeFunction * removed extra newline * SolidityFunctionWrapper uses makeTypeReference(), makeTypeReference returns StaticArray.class when array size is greater than max * trivial log line improvement * PR minor changes * rewrote makeTypeReference without recursion * test for 3D array support, introduced getSubTypeReference for Array subtype, refactor using getSubTypeReference * spotless * Support encoding a function, without calling it. (#972) generated functions support "send()" and sendAsync()", but sometimes we need the encoded function, without calling it. (e.g. if we want to have multiple signatures, or we want to perform the actual method send later) For that purpose, we added "encodeFunctionCall()", which returns the encoded function as-is. the returned byte array can be used by Web3j.ethCall(createEthCallTrasnaction() ) (for view/pure function), or can be wrapped with RawTransaction. * Stale bot (#998) * Stale Bot file * Stale Bot file * . * Update .github/stale.yml Co-Authored-By: Ivaylo Kirilov <iikirilov@gmail.com> * Added more exempted labels wip and awaiting-pr * Update stale.yml * added google analytics (#1002) Added google analytics for the new docs format * Release/4.4.1 (#1000) * bump for version 4.4.1 release * spotless * post release * run spotless in pipeline (#1003) * Extract encoding implementation using Java SPI mechanism * Add protected method to allow overriding ENS name resolution * Add hash function for any algorithm and Blake2b-256 implementation * Fix checkstyle errors * Add support for primitive Java types * Fix checkstyle * Add constant modifier to generate return types * Add address length flag and fix dynamic bytes wrapper type bug * Fix checkstyle * Fix checkstyle * Format consistently with other ABI test files * Optimize import * Fix name typo * Fix condition to match address parameter spec * Remove CLI option to avoid user being confused with an extra parameter * Change method visibility to allow specialization * Change method visibility to prevent calling non-static methods * Implement SPI for function decoding * Add bit size getter on NumericType * Make BytesType abstract for consistency with datatype model * Remove redundant Boolean primitive type overlapping with Solidity bool * Avoid loading ABI definitions twice * Add boolean primitive type support * Add support to ENS resolver and contract class injection * Fix indentation and simplify code * Make ENS constant public for re-usability * Revert function signature generating error for 2D arrays * Make method encoding functions protected in superclass so can be reused * Mahe default encoder and decoder public to allow overrides * Pass constructor flag as a parameter on deployment * Pass constructor flag as a parameter on deployment * Add generateSendTxForCalls flag to duplicate send/calls * Fix broken unit test * Fix checkstyle error * Extract encoding implementation using Java SPI mechanism * Add hash function for any algorithm and Blake2b-256 implementation * Fix checkstyle errors * Add support for primitive Java types * Change method visibility to prevent calling non-static methods * Remove redundant Boolean primitive type overlapping with Solidity bool * Make method encoding functions protected in superclass so can be reused * Mahe default encoder and decoder public to allow overrides * Fix broken unit test * Fix test unit after removing method throwing runtime exception * Fix checkstyle error * Add optional contract name in constructor * Fix checkstyle error * Fix test unit after removing method throwing runtime exception * Fix checkstyle error * Make generator constructors public for other plugins * Make generate functions public for other plugins * Add CLI options for contract name and address length to avoid coupling * Apply Spotless formatting to merged files * Remove duplicated method in merge * Fix test by declaring exception * Add constructor parameter * Fix Bytes type resolution and apply BaseEventResponse changes * Remove CHECKSTYLE comments * Update abi/src/main/java/org/web3j/abi/datatypes/Address.java Co-Authored-By: Ivaylo Kirilov <iikirilov@gmail.com> * Update abi/src/main/java/org/web3j/abi/FunctionReturnDecoder.java Co-Authored-By: Ivaylo Kirilov <iikirilov@gmail.com> * Move comment to Ethereum decoder * Cleanup code by using fields instead of parameters * Update abi/src/main/java/org/web3j/abi/spi/FunctionDecoderProvider.java Co-Authored-By: Ivaylo Kirilov <iikirilov@gmail.com> * Restrict bounds of type T to Comparable and Serializable * Fix renaming FunctionReturnDecoder and FunctionReturnDecoderProvider * Add missing method from rebasing with master * Add primitiveTypes flag to support Java types and update version * Release version 4.5.0
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces
javax.xml.bind.ValidationException
withRuntimeException
Where should the reviewer start?
StructuredDataEncoder.java
Why is it needed?
We don't want to depend on javafx