[feature] #4089: Add profiling support to iroha #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
added
iroha2-dev
Erigara
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
0x009922 and
DCNick3
as code owners
Erigara
force-pushed
the
perf_profiling
branch
from
6e73938
to
387081f
Compare
Erigara
commented
Jan 19, 2024
Erigara
commented
Jan 19, 2024
mversic
requested changes
Jan 19, 2024
mversic
reviewed
Jan 19, 2024
Erigara
force-pushed
the
perf_profiling
branch
from
707be08
to
f1f3534
Compare
mversic
reviewed
Jan 23, 2024
mversic
reviewed
Jan 23, 2024
mversic
reviewed
Jan 23, 2024
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
force-pushed
the
perf_profiling
branch
3 times, most recently
from
8db2805
to
ee6728e
Compare
Erigara
commented
Jan 23, 2024
mversic
previously approved these changes
Jan 23, 2024
DCNick3
reviewed
Jan 23, 2024
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
force-pushed
the
perf_profiling
branch
from
ee6728e
to
b8d2d33
Compare
…TING.md Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
force-pushed
the
perf_profiling
branch
from
b8d2d33
to
8d05c7c
Compare
mversic
approved these changes
Jan 24, 2024
DCNick3
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add compilation profile
profilingwhich preserve some debuginfo + force frame pointers (used by porfilers to symbolize functions in the stack trace).Add dockerfile with profiling support (used glibc instead of musl to be able to integrate with parca).
Add support to profile running wasm smartcontracts.
Linked issue
Closes #4083
Benefits
Data driven approach to optimization.