Skip to content

Commit

Permalink
Merge "[FAB-3244] Re-enable CouchDB bad connect unit test"
Browse files Browse the repository at this point in the history
  • Loading branch information
christo4ferris authored and Gerrit Code Review committed Apr 25, 2017
2 parents 014d760 + 2bd9005 commit cef3786
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions core/ledger/util/couchdb/couchdb_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,15 +209,12 @@ func TestDBBadDatabaseName(t *testing.T) {

func TestDBBadConnection(t *testing.T) {

// TestDBBadConnectionDef skipped since retry logic stalls the unit tests for two minutes.
// TODO Re-enable once configurable retry logic is introduced
t.Skip()

if ledgerconfig.IsCouchDBEnabled() {

//create a new instance and database object
//Limit the maxRetriesOnStartup to 3 in order to reduce time for the failure
_, err := CreateCouchInstance(badConnectURL, couchDBDef.Username, couchDBDef.Password,
couchDBDef.MaxRetries, couchDBDef.MaxRetriesOnStartup, couchDBDef.RequestTimeout)
couchDBDef.MaxRetries, 3, couchDBDef.RequestTimeout)
testutil.AssertError(t, err, fmt.Sprintf("Error should have been thrown for a bad connection"))
}
}
Expand Down

0 comments on commit cef3786

Please sign in to comment.