Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add push notifications expo protocol #745

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TimoGlastra
Copy link
Member

Adds push notification expo protocol to be used with Expo's push notification service

Similar to #736 and #699

Signed-off-by: Timo Glastra <timo@animo.id>
Copy link
Contributor

@berendsliedrecht berendsliedrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
Copy link
Member Author

This should also be updated to incorporate changes as discussed in #736

@TelegramSam
Copy link
Contributor

Is this ready to merge given the change in #736?

@swcurran
Copy link
Member

Reviewing PRs. I need some experts in mobile development to review and weigh in on this.

@TimoGlastra @blu3beri — could you of you please remove the other two files from this PR? The index.md file should will be a follow up to the merging we are doing with other PRs, and the fix in the other PR should be done in a separate (trivial) PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants