This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Change output location of protobuf generated Rust code #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 22, 2018 09:10
Signed-off-by: Bridger Herman <bridger@bitwise.io>
Note: this reverts commit hyperledger-archives@7906ac8, but this no longer matters because rustfmt does not touch the OUT_DIR. Signed-off-by: Bridger Herman <bridger@bitwise.io>
Signed-off-by: Bridger Herman <bridger@bitwise.io>
Signed-off-by: Bridger Herman <bridger@bitwise.io>
bridger-herman
force-pushed
the
protobuf-location
branch
from
712fb06
to
062b5a4
Compare
agunde406
requested review from
peterschwarz,
vaporos,
aludvik,
boydjohnson,
dcmiddle,
jsmitchell and
rbuysse
vaporos
approved these changes
Aug 22, 2018
rbuysse
approved these changes
Aug 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because from Rust 1.28, the
srcdirectory is no longer able to be modified. It is unclear if this is the best mechanism to use in the new structure, but it attempts to follow guidelines put forth by the Cargo documentation and the author of rust-protobuf.