Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): enable futures-util/alloc for tests #3601

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

seanmonstar
Copy link
Member

Closes #3599

@seanmonstar seanmonstar force-pushed the dev-futures-util-alloc branch 3 times, most recently from ec072f1 to 431cd7e Compare March 12, 2024 13:24
@seanmonstar
Copy link
Member Author

Hm, so the syntax to enable this on an optional feature works in newest Cargo, but the Cargo from 1.63 only understands half of it:

does not have feature futures-util. It has an optional dependency with that name, but that dependency uses the "dep:" syntax in the features table, so it does not have an implicit feature with that name.

Using ffi = ["dep:futures-util/alloc"] causes an error in all Cargo versions. How did one do this before it was "fixed"? Is Rust 1.63 just left out in the rain?

@seanmonstar
Copy link
Member Author

Following advice in this issue: rust-lang/cargo#10788

Changed to be futures-util?/alloc. 🤷

@seanmonstar seanmonstar merged commit 4d0c184 into master Mar 12, 2024
21 checks passed
@seanmonstar seanmonstar deleted the dev-futures-util-alloc branch March 12, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Futures-util dev dependency should require alloc feature
2 participants