New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(url): fix panic when questionmark is in fragment #1076

Merged

seanmonstar merged 1 commit into hyperium:master from sinkuu:fix_fragment_questionmark

Feb 25, 2017

Contributor

sinkuu commented Feb 25, 2017 •

edited

Loading

The commit messages match the guidelines in https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md#git-commit-guidelines

Url::parse panicked if a questionmark is in the fragment part:

panicked at 'attempt to subtract with overflow', src/uri.rs:207

This was found by cargo-fuzz


          fix(url): fix panic when questionmark is in fragment

8ba1f19

Member

seanmonstar commented Feb 25, 2017

Excellent, thank you!

seanmonstar merged commit 359f5ff into hyperium:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment