-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for Service::Error behavior should say it is protocol dependent #3659
Comments
Ah ok, yea, that's a problem with the docs. They should be updated to say that the behavior depends on the protocol version. It will abort the request however the protocol allows, either with some sort of RST_STREAM, or killing the connection if that doesn't exist. |
yinheli
added a commit
to yinheli/hyper
that referenced
this issue
Jul 22, 2024
…um#3659) The Service trait now includes a note about the behavior of returning an Error to a hyper server, which can cause the connection to be abruptly aborted depending on the protocol. This information is important for developers working with hyper servers.
yinheli
added a commit
to yinheli/hyper
that referenced
this issue
Jul 22, 2024
…m#3659) The Service trait now includes a note about the behavior of returning an Error to a hyper server, which can cause the connection to be abruptly aborted depending on the protocol. This information is important for developers working with hyper servers.
yinheli
added a commit
to yinheli/hyper
that referenced
this issue
Jul 23, 2024
…m#3659) The Service trait now includes a note about the behavior of returning an Error to a hyper server, which can cause the connection to be abruptly aborted depending on the protocol. This information is important for developers working with hyper servers.
seanmonstar
pushed a commit
that referenced
this issue
Jul 23, 2024
…#3712) The Service trait now includes a note about the behavior of returning an Error to a hyper server, which can cause the connection to be abruptly aborted depending on the protocol. This information is important for developers working with hyper servers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
1.3.1
Platform
Ubuntu 23.10
Description
I am using hyper-util
auto
server. I return an error from service. Instead of sending GOAWAY and closing connection hyper sends RST_STREAM. I looked into documentation and it looks like the connection should closed, but it sends RST.The text was updated successfully, but these errors were encountered: