Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reclaiming frames for dead streams. #262

Merged
merged 2 commits into from
Apr 24, 2018

Commits on Apr 20, 2018

  1. Avoid reclaiming frames for dead streams.

    In `clear_queue` we drop all the queued frames for a stream, but this doesn't
    take into account a buffered frame inside of the `FramedWrite`. This can lead
    to a panic when `reclaim_frame` tries to recover a frame onto a stream that has
    already been destroyed, or in general cause wrong behaviour.
    
    Instead, let's keep track of what frame is currently in-flight; then, when we
    `clear_queue` a stream with an in-flight data frame, mark the frame to be
    dropped instead of reclaimed.
    goffrie committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    6051fc1 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2018

  1. Configuration menu
    Copy the full SHA
    a49e5b4 View commit details
    Browse the repository at this point in the history