Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed complexity context for stdout logger. #6298

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Fixed complexity context for stdout logger. #6298

merged 3 commits into from
Nov 20, 2023

Conversation

xuanyanwow
Copy link
Member

No description provided.

@xuanyanwow xuanyanwow changed the title Fix stdout Fixed complexity context for stdout logger. Nov 20, 2023
@huangdijia
Copy link
Member

新特性是不是考虑合并到 3.1？

@xuanyanwow
Copy link
Member Author

新特性是不是考虑合并到 3.1？

不是新特性，原来就有的context，只是有bug 遇到无法转化为string的对象则会报错； tag标签的key移除后 context没有移除，导致后续的str_replace($search, $context, $this->getMessage((string) $message, $level, $tags)); 产生预期外的替换效果

@xuanyanwow xuanyanwow marked this pull request as ready for review November 20, 2023 03:13
@limingxinleo limingxinleo merged commit bba29c4 into hyperf:master Nov 20, 2023
56 checks passed
@xuanyanwow xuanyanwow deleted the fix-stdout branch November 21, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangdijia huangdijia huangdijia approved these changes

@limingxinleo limingxinleo limingxinleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuanyanwow @huangdijia @limingxinleo