Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support API Token and support mutiple records has same name, eg: A & TXT #5

Merged
merged 3 commits into from
Jun 27, 2020

Conversation

Rp70
Copy link
Contributor

@Rp70 Rp70 commented Jun 23, 2020

I want to add support for API Token and mutiple records has same name, eg: A & TXT. I also changed the way we pass HTTP Headers to curl. Let me know if you have any questions. Thank you!

@hyecheol123
Copy link
Owner

Oh, I did not think about multiple records having same name.
Looks like the types of record has been hard-coded, and I will further modify the code before merge so that I can figure out proper way to put those along with the update targets.

Moreover, this is something related to #4 , and this is one of my future improvement plan of this scripts.

Thanks for providing me a valuable improvement!!

@hyecheol123
Copy link
Owner

@Rp70 Do you prefer me to merge your code to a separated branch before I modify your code, or to work on your repository (By submitting PR on your branch) then merge the final work to my repository's master branch?

@hyecheol123 hyecheol123 added the enhancement New feature or request label Jun 23, 2020
@hyecheol123 hyecheol123 self-assigned this Jun 23, 2020
@hyecheol123 hyecheol123 linked an issue Jun 23, 2020 that may be closed by this pull request
cloudflare_dynamic_ip_update.bash Outdated Show resolved Hide resolved
@Rp70
Copy link
Contributor Author

Rp70 commented Jun 24, 2020

@Rp70 Do you prefer me to merge your code to a separated branch before I modify your code, or to work on your repository (By submitting PR on your branch) then merge the final work to my repository's master branch?

Hi! I'm new to GitHub and all kinds of git things so please feel free to do what you see it's convenient to you. I need to learn the both ways. Thank you!

@hyecheol123
Copy link
Owner

Hi! I'm new to GitHub and all kinds of git things so please feel free to do what you see it's convenient to you. I need to learn the both ways. Thank you!

I prefer to work on your repository and merge fresh codes here.

  • You do not need to create any additional PR to update. This PR will automatically updated once the code changed.
  • I will work on your repository, and you can review my change before we go

Again, thanks for your feedbacks.

Copy link
Owner

@hyecheol123 hyecheol123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ubuntu 20.04 LTS (WSL 2)

Config File Checked. Good to Merge

@hyecheol123 hyecheol123 merged commit be290ec into hyecheol123:master Jun 27, 2020
@Rp70
Copy link
Contributor Author

Rp70 commented Jun 28, 2020

I see the new update. Thanks so much!

@hyecheol123
Copy link
Owner

@Rp70 I tested the code, but if there's bug, please let me know.

Again, Thanks for your contribution

@altanalaybeyoglu
Copy link

Hi,
When I execute cloudflare_dynamic_ip_update.bash, I take "Error While updating .... " message.
I check, API's Permissions. They are ok.
Also My APIKey is working too

Thanks for script!

@altanalaybeyoglu
Copy link

Hi,
When I execute cloudflare_dynamic_ip_update.bash, I take "Error While updating .... " message.
I check, API's Permissions. They are ok.
Also My APIKey is working too

Thanks for script!

I think, It is about CF. My domain is example.tk so they say "You cannot use this API for domains with a .cf, .ga, .gq, .ml, or .tk TLD (top-level domain)."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] API Token
3 participants