-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support API Token and support mutiple records has same name, eg: A & TXT #5
Conversation
Oh, I did not think about multiple records having same name. Moreover, this is something related to #4 , and this is one of my future improvement plan of this scripts. Thanks for providing me a valuable improvement!! |
@Rp70 Do you prefer me to merge your code to a separated branch before I modify your code, or to work on your repository (By submitting PR on your branch) then merge the final work to my repository's master branch? |
Hi! I'm new to GitHub and all kinds of git things so please feel free to do what you see it's convenient to you. I need to learn the both ways. Thank you! |
I prefer to work on your repository and merge fresh codes here.
Again, thanks for your feedbacks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Ubuntu 20.04 LTS (WSL 2)
Config File Checked. Good to Merge
I see the new update. Thanks so much! |
@Rp70 I tested the code, but if there's bug, please let me know. Again, Thanks for your contribution |
Hi, Thanks for script! |
I think, It is about CF. My domain is example.tk so they say "You cannot use this API for domains with a .cf, .ga, .gq, .ml, or .tk TLD (top-level domain)." |
I want to add support for API Token and mutiple records has same name, eg: A & TXT. I also changed the way we pass HTTP Headers to curl. Let me know if you have any questions. Thank you!