Fix legacy InstrumentComponent load (#1759) #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in this issue it was reported that upgrading a drumkit does discard all instrument layers except the first one in 1.2.0. The legacy Boss_DR-110 kit used for unit tests as well as some core methods were patched in order to make unit tests catch this issue.
while refactoring the different versions of legacy kit loadings a bug was introduced which caused only the first layer of an instrument being loaded. fixes hydrogen-music#1759
in temp folder name. using ":" results in invalid file paths on Windows
theGreatWhiteShark
force-pushed
the
phil-fix-1759
branch
from
026ba2b
to
73770d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while refactoring the different versions of legacy kit loadings a bug was introduced which caused only the first layer of an instrument being loaded. This is now also covered by an unit test.
fixes #1759