Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spans empty in proc-macro2 >= 1.0.57 #729

Closed
MingweiSamuel opened this issue May 30, 2023 · 6 comments
Closed

Spans empty in proc-macro2 >= 1.0.57 #729

MingweiSamuel opened this issue May 30, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@MingweiSamuel
Copy link
Member

Currently working with syn 2.0.14, seems broken in syn 2.0.18
@MingweiSamuel MingweiSamuel added the bug Something isn't working label May 30, 2023
@jhellerstein jhellerstein added this to the 0.3 release milestone Jun 20, 2023
@jhellerstein jhellerstein added the P0 Highest priority label Jun 20, 2023
@MingweiSamuel MingweiSamuel changed the title Spans empty in latest syn Spans empty in syn >= 2.0.17 Jun 20, 2023
@MingweiSamuel
Copy link
Member Author

broken by

 Updating proc-macro2 v1.0.56 -> v1.0.60
 Updating quote v1.0.26 -> v1.0.28
 Updating syn v2.0.16 -> v2.0.17

@MingweiSamuel MingweiSamuel changed the title Spans empty in syn >= 2.0.17 Spans empty in proc-macro2 >= 1.0.57 Jun 20, 2023
@MingweiSamuel
Copy link
Member Author

broken by proc-macro2 >= 1.0.57

dtolnay/proc-macro2#383

@MingweiSamuel MingweiSamuel removed the P0 Highest priority label Jun 20, 2023
@MingweiSamuel MingweiSamuel removed their assignment Jun 28, 2023
@MingweiSamuel
Copy link
Member Author

waiting for rust-lang/rust#111571 to trickle through the ecosystem

@zzlk zzlk modified the milestones: 0.3 release, 0.4 release Jun 29, 2023
@jhellerstein jhellerstein added the P2 Medium priority label Jul 3, 2023
@MingweiSamuel MingweiSamuel changed the title Spans empty in proc-macro2 >= 1.0.57 Spans empty in proc-macro2 >= 1.0.57 (check hydro.run playground diagnostics) Jul 3, 2023
@MingweiSamuel
Copy link
Member Author

MingweiSamuel commented Jul 3, 2023 •
edited
Loading

#801

probably breaks playground diagnostics

hydroflow/website_playground/src/lib.rs

Lines 70 to 73 in 7dbd5e2

JSSpan {
start: span.start().into(),
end: Some(span.end().into()),
}

(edit: It doesn't)

@jhellerstein jhellerstein removed this from the 0.4 release milestone Jul 31, 2023
@jhellerstein jhellerstein removed the P2 Medium priority label Jul 31, 2023
@MingweiSamuel MingweiSamuel changed the title Spans empty in proc-macro2 >= 1.0.57 (check hydro.run playground diagnostics) Spans empty in proc-macro2 >= 1.0.57 Nov 8, 2023
@MingweiSamuel MingweiSamuel added this to the 0.7 Release milestone Mar 26, 2024
@MingweiSamuel
Copy link
Member Author

Will check if upstream has changed, seems promising

@MingweiSamuel
Copy link
Member Author

Not fixed as of 1.0.79
dtolnay/proc-macro2#397

@MingweiSamuel MingweiSamuel removed their assignment Mar 26, 2024
@MingweiSamuel MingweiSamuel removed this from the 0.7 Release milestone Mar 26, 2024
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Aug 28, 2024
@MingweiSamuel
refactor(hydroflow_lang): cleanup handling of span locations hydro-pr…
d4aa15b 
…oject#729 hydro-project#1268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jhellerstein @zzlk @MingweiSamuel